Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrank custom games after fixed time #1011

Open
Askaholic opened this issue Mar 25, 2024 · 4 comments
Open

Unrank custom games after fixed time #1011

Askaholic opened this issue Mar 25, 2024 · 4 comments

Comments

@Askaholic
Copy link
Collaborator

Askaholic commented Mar 25, 2024

As per discussion on Discord, it was requested to change the unrank timer for custom games to a fixed time of 2 minutes. Currently the time is based on number of players in the game:

limit = len(self.players) * 60

This should be a very simple change to the function linked above. Probably will need to adjust some unit tests as well.

Discord thread: https://discord.com/channels/197033481883222026/1221544919735468042

@MostLostNoob
Copy link

MostLostNoob commented Mar 25, 2024

Per that discord conversation, the current system is based on real time minutes * number of players in the game, but the suggestion is to change that to a flat/static 2 game time minutes instead.

@Askaholic
Copy link
Collaborator Author

Unfortunately the game time isn't available to the server. It will have to be based on real time.

@magge-faf
Copy link

Doesn't real time minutes mean, when someone lost connection or crashed in the very early phase, that his opponent can just press pause, and sips his tea for two minutes, then unpauses the game to make it ranked in his favor, when the game ends shortly after?

Or does some event/security prevent that possibility in the first place?

@BlackYps
Copy link
Collaborator

BlackYps commented May 7, 2024

Yes.
No, there is no protection against this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants