Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework display of ratings in player info window #2991

Open
BlackYps opened this issue Jun 11, 2023 · 1 comment
Open

Rework display of ratings in player info window #2991

BlackYps opened this issue Jun 11, 2023 · 1 comment

Comments

@BlackYps
Copy link
Collaborator

The order of ratings doesn't match the order in the leaderboard tab of the client. 3v3 is listed last. Additionally the unused 4v4 share until death rating should be hidden. Maybe we should entirely rework how the display of ratings works in this window. Currently all the leaderboards get fetched, but the leaderboards don't have a flag if they are active, only the leagues have. If we rework it to fetch the leagues like in the leaderboard tab, then we can be consistent. The only question is how we want to treat global rating.
grafik

@Brutus5000
Copy link
Member

This is more than a client issue. There is no sort order defined, so the response can come in any order (usually order of last insertion/update). If you want a sorting you need to add it to the db, api and then sort by it in the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants