Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all sub classes that are used by fields extend MonoBehaviour so they can be used as property components within the inspector #211

Open
thestonefox opened this issue Nov 14, 2018 · 3 comments
Open

Make all sub classes that are used by fields extend MonoBehaviour so they can be used as property components within the inspector #211

thestonefox opened this issue Nov 14, 2018 · 3 comments
Labels
chore Something mundane but must be done w_feature waffle.io label
Projects
VRTK

Comments

@thestonefox
Copy link
Member

No description provided.

@thestonefox
Copy link
Member Author

For use with #210

@thestonefox thestonefox added enhancement Making something better chore Something mundane but must be done w_ready waffle.io label and removed enhancement Making something better labels Nov 14, 2018
@thestonefox thestonefox added this to the Milestone 3 milestone Nov 14, 2018
@thestonefox
Copy link
Member Author

thestonefox commented Nov 15, 2018 •
edited

Candidates

  • ObjectPointer.Element
  • TransformData

Event Data

(should this be a monobehaviour? I don't think you should be able to configure event data via a component imho)

  • PointsCast.EventData
  • ActionCollisionContainer.EventData
  • ActionCollisionConsumer.EventData
  • ActionCollisionPublisher.Payload (this is the data for the event, probably should be renamed too to EventData?)
  • CollisionNotifier.EventData
  • ObjectDistanceComparator.EventData
  • ObjectFollower.EventData
  • TransformPropertyApplier.EventData
  • CameraColorOverlay.EventData
  • PointsRenderer.EventData

Ignore?

Probably just leaves these as they are

  • ActionRegistrar.ActionSource (this is a struct because we need the serialization)
  • GameObjectEventStack.EventElements (this is just a collection of events so can be ignored)
  • GameObjectRelation.Relation (unsure why this is a class, maybe should be a struct?)
  • RulesMatcher.Element(dubious whether this should be MonoBehaviour)

@bddckr bddckr removed this from the Milestone 3 milestone Dec 30, 2018
@thestonefox thestonefox added w_feature waffle.io label and removed w_ready waffle.io label labels Feb 20, 2019
@thestonefox
Copy link
Member Author

ObjectPointer.Element is now it's own PointerElement class anyway.

@thestonefox thestonefox added this to To do in VRTK May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Something mundane but must be done w_feature waffle.io label
Projects
VRTK
  
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bddckr @thestonefox