[HOLD for payment 2023-10-02] [$1000] Profile - Unable to upload .svg file as profile photo

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Settings > Profile > Click on profile photo > Upload photo
3. Upload a svg file

Expected Result:

The svg file is uploaded successfully for profile photo

Actual Result:

The svg file fails to upload
Attachment error
An error occurred while selecting a corrupted attachment, please try another file

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.63-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6188965_Screen_Recording_20230905_165337_Photos__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01daf722c26b685a79
• Upwork Job ID: 1699583361425006592
• Last Price Increase: 2023-09-18
• Automatic offers:
• s77rt | Contributor | 26541772
• rmm-fl | Contributor | 26767787

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

I can't upload a .SVG file via BrowserStack for Android native as that file type isn't supported in the emulator. @s77rt don't suppose you'd mind giving this a quick go to reproduce?

In the meantime, @lanitochka17 it might be helpful to include the specific SVG file you used in this issue for us to check as well. Thanks!

[s77rt]

@trjExpensify I can reproduce. The image looks blank in the image picker.

Screen.Recording.2023-09-06.at.1.51.30.AM.mov

[trjExpensify]

Thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01daf722c26b685a79

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[trjExpensify]

@s77rt if you want the C+ on it coz' you helped, here let me know!

[s77rt]

I would assume the bug to be upstream. @fedirjh Can I take this one?

[fedirjh]

@s77rt Sure, go ahead.

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[trjExpensify]

Done!

[melvin-bot]

@trjExpensify, @s77rt Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@trjExpensify, @s77rt Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

Waiting for proposals!

[melvin-bot]

📣 @rmm-fl 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[rmm-fl]

Offer accepted & draft PR is here #27834
Going through the checklist now!

[rmm-fl]

Checklist done #27834 - now it's ready for review @s77rt

[melvin-bot]

🎯 ⚡️ Woah @s77rt / @rmm-fl, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @rmm-fl got assigned: 2023-09-20 01:35:54 Z
• when the PR got merged: 2023-09-21 03:13:47 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update picker to avoid showing svg images on android #27834

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment offer (Contributor)
• @rmm-fl requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: N/A. This bug is in the upstream repo (react-native-image-picker)
• The offending PR has been commented on: N/A
• A discussion in #expensify-bugs has been started: N/A
• Determine if we should create a regression test for this bug: No

[Julesssss]

Ready for payment today

[trjExpensify]

Works for me, @s77rt! Confirming payments as follows:

• $1,500 to @s77rt for the C+ review & #urgency bonus
• $1,500 to @rmm-fl for the bug fix & #urgency bonus

[trjExpensify]

Sent @s77rt an offer. Once confirmed on the above, I'll settle up with you both!

[rmm-fl]

Will the project price in my contract be automatically updated to include the 50% bonus? Thanks!

[trjExpensify]

Will the project price in my contract be automatically updated to include the 50% bonus? Thanks!

Yeah, I add it when settling up! :)

[s77rt]

@trjExpensify Accepted! Thanks!

[trjExpensify]

Perfect, settled up with you both. Closing!