[PAID] [$1000] Tooltip is missing on rotate image button on avatar crop modal

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Profile > Upload Photo
2. It will show image crop modal
3. Hover over rotate image button
4. Hover over the Zoom image button

Expected Result:

It should show tooltip with text "Rotate" and "Zoom" respectively

Actual Result:

No tooltip is shown

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.84-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

NoTooltipCropView.mov

Expensify/Expensify Issue URL:
Issue reported by: @PrashantMangukiya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678727788153259

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01040e37fe8a2e89a8
• Upwork Job ID: 1641539424957095936
• Last Price Increase: 2023-03-30

[MelvinBot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[anmurali]

I am not sure this is a bug. Discussing here

[aman-atg]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltip is missing on rotate image button on avatar crop modal

What is the root cause of that problem?

The root cause of this problem is that the tooltip has not been implemented on the button.

What changes do you think we should make in order to solve the problem?

We just need to wrap rotate button with Tooltip component in AvatarCropModal.js

What alternative solutions did you explore? (Optional)

Additionally, we can add another tooltip for the zoom icon

[MelvinBot]

📣 @aman-atg! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[MelvinBot]

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@anmurali Still overdue 6 days?! Let's take care of this!

[MelvinBot]

@anmurali this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MelvinBot]

@anmurali Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[MelvinBot]

@anmurali Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01040e37fe8a2e89a8

[MelvinBot]

Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.

[anmurali]

Added the fact that the Zoom icon has no tooltip either and set this as an external job

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[MelvinBot]

📣 @PrashantMangukiya You have been assigned to this job by @arosiclair!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[PrashantMangukiya]

Thanks @arosiclair Applied to job on Upwork. Will submit PR within two hours.

[PrashantMangukiya]

@eVoloshchak @arosiclair PR is ready for review.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.96-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add tooltip to rotate image button and zoom slider #16920

If no regressions arise, payment will be issued on 2023-04-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak / @arosiclair] The PR that introduced the bug has been identified. Link to the PR: Feature Request - Profile / Workspace - Allow avatar editing via cropping, rotation and zooming #8511
• [@eVoloshchak / @arosiclair] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Feature Request - Profile / Workspace - Allow avatar editing via cropping, rotation and zooming #8511 (comment)
• [@eVoloshchak / @arosiclair] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1681160202546059
• [@anmurali] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[arosiclair]

Partially filled BZ checklist

[eVoloshchak]

Not overdue, this is waiting for BugZero Checklist to be finished and payments to be settled

[PrashantMangukiya]

Ping for Upwork.

[PrashantMangukiya]

@anmurali Offer accepted on Upwork. Just a reminder. I am also eligible for Timeline and Reporting bonus for this issue.

[anmurali]

@PrashantMangukiya - paid
@eVoloshchak do we need to add a regression test here?

[eVoloshchak]

Regression Test Proposal

1. Navigate to settings by clicking on the user avatar over LHN
2. Click on Profile
3. Click on the avatar edit icon
4. Click on "upload photo" and upload an image
5. Hover over the zoom slider and "rotate" button and verify that the tooltip appears when hovering
6. Verify the tooltip info is aligned with the function of each button
7. Verify the tooltip disappears when the cursor is moved away

Do we agree 👍 or 👎

[anmurali]

https://github.com/Expensify/Expensify/issues/277058

Paid and regression test proposal added