Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused method in haystack reporter class #779

Open
virendraagarwal opened this issue Sep 13, 2019 · 0 comments
Open

Unused method in haystack reporter class #779

virendraagarwal opened this issue Sep 13, 2019 · 0 comments

Comments

@virendraagarwal
Copy link

HI Team,

I found method in Haystack reporter. Ii is never used for conversion of Zipkin span to haystack span is there any specific use case for this method or it is dead code.

https://github.com/ExpediaDotCom/spring-cloud-sleuth-haystack-reporter/blob/master/src/main/java/com/expedia/www/spring/cloud/sleuth/haystack/reporter/reporters/HaystackReporter.java

private Log buildLog(Long timestamp, String key, String value) {
final Log.Builder logBuilder = Log.newBuilder();

logBuilder.setTimestamp(timestamp);
logBuilder.addFields(buildTag(key, value));

return logBuilder.build();
}

Thanks
Virendra Agarwal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant