Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Three.js Editor Scripting #87

Open
tjduigna opened this issue May 13, 2022 · 0 comments
Open

Adding Three.js Editor Scripting #87

tjduigna opened this issue May 13, 2022 · 0 comments

Comments

@tjduigna
Copy link
Contributor

tjduigna commented May 13, 2022

We use a custom fork of the three.js repository where we maintain edits to the three.js Editor component useful for materials manipulations. The editor subdirectory includes vendored JS dependencies in a js/libs directory which are not 100% compatible with our use case.

The usage of CodeMirror in the Editor takes advantage of a TernServer for javascript autocomplete. The TernServer code refers to the ternjs module as a global. In order to support CodeMirror functionality in the Editor, we need to resolve the issue about tern being a global in the codemirror source code.

Relevant file in three.js: editor/js/Script.js

Relevant file in wave: src/components/ThreejsEditorModal.jsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant