Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlinks break the table #77

Open
marinalimeira opened this issue May 16, 2022 · 2 comments
Open

Hyperlinks break the table #77

marinalimeira opened this issue May 16, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@marinalimeira
Copy link

I am trying to add hyperlinks to my bubble-table, but OSC 8 hyperlinks don't work when inside the table.

I am using this function to create the link:

func hyperlink(text string, url string) string {
	return "\x1b]8;;" + url + "\x07" + text + "\x1b]8;;\x07"
}

You can see an example code in this Gist. It renders like this:
Screenshot 2022-05-16 at 12 38 24

Same table, without hyperlinks:
Screenshot 2022-05-16 at 12 39 23

@Evertras Evertras added the bug Something isn't working label May 16, 2022
@Evertras
Copy link
Owner

Apologies for the delay on responding to this, I've been a bit swamped by my day job. <3

I'm unfamiliar with OSC 8 hyperlinks and I've done some brief investigations. It appears there's an open issue regarding hyperlinks here as well in the underlying library that we use: muesli/reflow#45

This may be difficult to fix on our end if the underlying library also contains this issue. Open to thoughts.

@marinalimeira
Copy link
Author

No problem @Evertras! Thank you for taking a look into the issue.

I will follow the issue in reflow, indeed it's hard to fix it here if reflow breaks the text too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants