Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cursor back to avoid accumulated movement #411

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Move cursor back to avoid accumulated movement #411

wants to merge 2 commits into from

Conversation

maffe
Copy link

@maffe maffe commented Aug 13, 2020

Fixes #410

@codeclimate
Copy link

codeclimate bot commented Aug 13, 2020

Code Climate has analyzed commit b37d66b and detected 0 issues on this pull request.

View more on Code Climate.

@AppVeyorBot
Copy link

WIP-2020.08.13-12.32.26 completed (commit 1fa3b5e9eb)
Artifacts:
Build.log
CHANGELOG.md
CHANGELOG_THIS_RELEASE.bb
CHANGELOG_THIS_RELEASE.md
EventGhost_WIP-2020.08.13-12.32.26_Setup.exe

kdschlosser
kdschlosser requested changes Aug 14, 2020
View reviewed changes
Copy link
Member

@kdschlosser kdschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be a short delay between the 2 from what I have seen. adding time.sleep(0.04) between the 2 should do the trick. Other then that It looks good.

@maffe
Copy link
Author

maffe commented Aug 14, 2020

I’ve seen the sleep call in proposed solutions, but I don’t want to introduce arbitrary delays, in my tests it worked without it.

@kdschlosser
Copy link
Member

it's a 40 millisecond delay. I am fairly sure it is there so that the Windows notification system is able to make it's callbacks before the next move takes place. I know that If you use the Move Mouse action and you do not put a wait and then add the action to click a mouse button, it doesn't work properly but if you add a wait in between the 2 everything works.

If it was a semi long delay I would be concerned with it but being that the delay is only 40 milliseconds I am not concerned with it.

@kdschlosser
Copy link
Member

also you need to push the commit with the changes for the delay in order for them to be added to the PR

@maffe
Add delay between mouse movements
ec38eb1 
In my tests the delay was not needed, but it was requested here: EventGhost#411 (review)
@AppVeyorBot
Copy link

972-master completed (commit 4a2a2ee2a4)
Artifacts:
Build.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdschlosser kdschlosser Awaiting requested review from kdschlosser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Action "Turn monitor on" shifts cursor
3 participants
@maffe @AppVeyorBot @kdschlosser