Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the meme editor #11

Open
4 of 5 tasks
SpiffGreen opened this issue Mar 1, 2022 · 4 comments · Fixed by #24
Open
4 of 5 tasks

Fix the meme editor #11

SpiffGreen opened this issue Mar 1, 2022 · 4 comments · Fixed by #24
Assignees
@SpiffGreen
Labels
bug Something isn't working enhancement New feature or request Priority: High This issue or pull request is very urgent and should be top priority Status: In progress This issue or pull request is currently being worked on
Projects
Rocketmeme

Comments

@SpiffGreen
Copy link
Collaborator

SpiffGreen commented Mar 1, 2022 •
edited by Evavic44

  • Make meme editor responsive
  • Add state recognition
    • If a text element is selected then formatting and styling tools for text should be activated using the text element's ID
    • If an image is selected then formatting and styling tools for image should be activated using the image element's ID
  • Create download dialog for download options when download button is clicked
  • Make Add Image button use image from file system picked.
  • Create Meme Template Section.
    • Each image when clicked should be used as the current image template
    • There should be only one meme template in the EditView Component so upon clicking a meme template the old one is replaced
@SpiffGreen SpiffGreen added bug Something isn't working enhancement New feature or request labels Mar 1, 2022
@SpiffGreen SpiffGreen self-assigned this Mar 1, 2022
@Evavic44 Evavic44 added this to To do in Rocketmeme Mar 1, 2022
@Evavic44
Copy link
Owner

Evavic44 commented Mar 2, 2022 •
edited

Can you please make this a checkbox so we can tick as completed?
As for the meme editor, I've made it responsive, though there are still a few things to update.

  • Make meme editor responsive.

I'll still send a PR for the final changes so we can track this issue.

@SpiffGreen SpiffGreen moved this from To do to In progress in Rocketmeme Mar 6, 2022
@Evavic44 Evavic44 added Priority: High This issue or pull request is very urgent and should be top priority Status: In progress This issue or pull request is currently being worked on labels Mar 7, 2022
@Evavic44 Evavic44 mentioned this issue Mar 7, 2022
Merged
@Evavic44
Copy link
Owner

Evavic44 commented Mar 8, 2022

Image selection working perfectly. Just created this meme. 🤩

rocketmeme-1646717310032

@Evavic44 Evavic44 linked a pull request Mar 9, 2022 that will close this issue
Editor fix #24
Merged
@Evavic44
Copy link
Owner

@all-contributors please add @SpiffGreen for bug, code, ideas, review

@allcontributors allcontributors bot mentioned this issue Mar 12, 2022
Merged
@allcontributors
Copy link
Contributor

@Evavic44

I've put up a pull request to add @SpiffGreen! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SpiffGreen SpiffGreen

Labels
bug Something isn't working enhancement New feature or request Priority: High This issue or pull request is very urgent and should be top priority Status: In progress This issue or pull request is currently being worked on
Projects
Rocketmeme
In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editor fix Evavic44/rocketmeme
2 participants
@Evavic44 @SpiffGreen