Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-update mechanism #22

Open
Etuldan opened this issue Dec 13, 2022 · 11 comments
Open

Self-update mechanism #22

Etuldan opened this issue Dec 13, 2022 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@Etuldan
Copy link
Owner

Etuldan commented Dec 13, 2022

Adding a self update mecanism could be nice.

@Etuldan Etuldan added the enhancement New feature or request label Dec 13, 2022
@Etuldan
Copy link
Owner Author

Etuldan commented Dec 13, 2022

@Etuldan Etuldan self-assigned this Dec 14, 2022
@jboby93
Copy link
Collaborator

jboby93 commented Dec 15, 2022

ooo neat idea, i'm going to experiment with this on my repo. started some UI work for it. wondering if there will be a good way to do it for both the obs27 and obs28 versions without them downloading the wrong one... maybe it can check the contents of the release tag for both program and websocket version indicators? or maybe it can ask which one to download? i started with my base obs27 branch, but it should just be literal copy and paste the changes into the obs28 branches

@Etuldan
Copy link
Owner Author

Etuldan commented Dec 15, 2022

obs27 support will be dropped for MidiControl.

@jboby93
Copy link
Collaborator

jboby93 commented Dec 15, 2022

Okay, I'll go ahead and port the progress so far to an obs28 branch. Started with obs27 because I use an ASIO source capture plugin that hasn't been updated in some time and likely won't... I may just maintain that release on my own fork.

@Etuldan
Copy link
Owner Author

Etuldan commented Dec 16, 2022

Using this version of OBS-Websocket on a 27- OBS should works for MidiControl ? https://obsproject.com/forum/resources/obs-websocket-remote-control-obs-studio-using-websockets.466/updates#resource-update-4796

@jboby93
Copy link
Collaborator

jboby93 commented Dec 16, 2022

hmm, didn't know that the 5.0 websocket version was also available for OBS 27. i'll have to give that a try!

@Etuldan
Copy link
Owner Author

Etuldan commented Dec 29, 2022

Will be probably in a 3rd party nugget ;)

@jboby93
Copy link
Collaborator

jboby93 commented Dec 29, 2022

i haven’t forgotten about this, just been busy and distracted with the holiday season and work and such lol. i found the correct ws plugins and i’m gonna try the 5.0 ws for obs 27 hopefully today, if it works then i’ll just move forward on that version from there on. the self-update is almost done, it sorts through the releases to find the highest version number based on release tags and shows the changelog, checking on startup is optional and off by default (first run of the new version shows a prompt to enable it or not), though i’m wondering whether the best approach from there would be to either: a) download the setup exe if the user accepts, and then run it automatically if they choose to, or b) just open the github release page in a browser.

hope you had a good holiday! i’ll see if i can auto-merge the changes you made for the project version; i’m using visual studio 2017 currently, i’m assuming you upgraded it to the latest 2022 version?

@Etuldan
Copy link
Owner Author

Etuldan commented Dec 29, 2022

Don't put too much effort on the selfupdate mecanism, as I'm working on it on spare time.
VSStudio 2017 should works.

@Etuldan
Copy link
Owner Author

Etuldan commented Dec 31, 2022

@jboby93
Copy link
Collaborator

jboby93 commented Jan 24, 2023

The ws5.0 version of MidiControl works fine with OBS 27 running ws5.0. I see you've started a self-update mechanism; I also have it working on my branch, although differently, and also added a small ux enhancement (hotkey tooltips show the mapped device/note/cc) and a bug fix (OBSControl.ShowFilter() wasn't working properly, discovered this after skimming through my VOD this evening and realizing my voice effect didn't turn on lol). Feel free to take and include those changes in the next release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants