Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide by zero bug in ercf.py code due to filament misfeed in filament block (Sensorless branch) #158

Open
nightime7 opened this issue Oct 2, 2022 · 1 comment

Comments

@nightime7
Copy link

Lines 409-411 in ercf.py include the below logic:

409 self._load_to_end_of_bowden(load_length-encoder_moved)
410 final_position = self._counter.get_distance()
411 ratio = load_length / final_position

if self_counter-get_distance() returns '0' due to misfeed of filament in cartrige, this will cause an internal error in klipper and shutdown the printer.
There should be applied a check for zero value in final_position prior to line 411.

@jwhite
Copy link

jwhite commented Oct 28, 2022

I got hit by this. Create a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants