Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifiying hyperparameters in autokoopman function #37

Open
TUMcps opened this issue Oct 25, 2022 · 1 comment
Open

Specifiying hyperparameters in autokoopman function #37

TUMcps opened this issue Oct 25, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@TUMcps
Copy link
Contributor

TUMcps commented Oct 25, 2022

I think we should use the same method for specifying values and ranges for all hyperparameters (n_obs, rank, lengthscale, enc_dim, n_layers). Currently this is in my opinion quite inconsistent since for n_obs one for example specifies the maximum number tried, while for rank one has to specify the range and gets an error when one tries to use a fixed rank. I would propose that for all hyperparameters one can either specify a single value, a range (start, stop), or a range with step size (start, stop, step).

@EthanJamesLew EthanJamesLew added the enhancement New feature or request label Oct 26, 2022
@EthanJamesLew EthanJamesLew added this to the HSCC Submission milestone Oct 26, 2022
@EthanJamesLew
Copy link
Owner

I fixed n_obs and rank. I don't think it makes sense to have lengthscale in the form of (start, stop, step) because it's a continuous hyperparameter (just (start, stop)) and in logscale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants