Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality assurance using Font Bakery #1

Open
felipesanches opened this issue Apr 9, 2020 · 8 comments
Open

Quality assurance using Font Bakery #1

felipesanches opened this issue Apr 9, 2020 · 8 comments

Comments

@felipesanches
Copy link

Hello, Tyler,

My name is Felipe Sanches and I work on the development of Font Bakery, a quality assurance tool used by Google Fonts to ensure adherence to a set of criteria prior to publishing the font files to Google servers.

You can learn more about the tool at https://font-bakery.readthedocs.io/en/latest/ (we even have an introductory video there explaining the overall purpose of the project)

I would like to offer you help in setting up this font project repo (and maybe other repos as well) to run Font Bakery automatically at each new commit pushed to master branch. And then I'd like to show you the check results and see if there's anything unclear about them that we could improve in the tool, or any actual issues in the font project that we could fix to make it more likely to be added to the Google Fonts collection.

What do you think?
I hope this is useful for you ;-)

cheers,
Felipe

@sursly
Copy link
Member

sursly commented Apr 9, 2020

Sounds good @felipesanches ! I've been running the variable files through http://fontbakery.graphicore.de periodically. Happy to tweak things on my end to make it as usable as possible.

@felipesanches
Copy link
Author

ah! That's good! That webapp tends to be in sync with the command line tool.

Are there check results that you do not understand? I'd be glad to help.

@sursly
Copy link
Member

sursly commented Apr 9, 2020

I am getting some errors that I didn't used to (did my stuff already head to google fonts?). Here's the latest for one that I thought was almost in the clear (grandstander): https://fontbakery.graphicore.de/report/fdb52a58-c0b5-42cc-9b4f-53ef27121cb0

@felipesanches
Copy link
Author

OK, I see a few ERRORs in there. These are things that I have to fix. I'll try to understand what happened there.

To be clear, a FAIL is a problem with the font while an ERROR is a problem with the tool (Font Bakery itself seems broken in this case).

I will open new issues on the Font Bakery issue tracker at https://github.com/googlefonts/fontbakery/issues so that we don't forget to fix these problems. If you see anything that seems wrong, please don't think twice before reporting at our issue tracker ;-D

@sursly
Copy link
Member

sursly commented Apr 9, 2020

Oh wow, that's good to know between Fail and Error (I had no clue). I'm tackling fails now...

@sursly
Copy link
Member

sursly commented Apr 9, 2020

Question @felipesanches: I get the failure "com.google.fonts/check/repo/vf_has_static_fonts A static fonts directory with at least two fonts must accompany variable fonts
"

But I'm just uploading one TTF VF file. Should I disregard this? I definitely have a static folder (and files) in my repo.

@sursly
Copy link
Member

sursly commented Apr 9, 2020

@davelab6
Copy link
Collaborator

You can disregard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants