Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Danger tests #242

Open
lfarah opened this issue Oct 7, 2016 · 3 comments
Open

New Danger tests #242

lfarah opened this issue Oct 7, 2016 · 3 comments
Milestone

Comments

@lfarah
Copy link
Collaborator

lfarah commented Oct 7, 2016

so now we need to find a way to

  • Ensure documentation in the method by checking for ///
  • Ensure that each new PR of a new extension has a Test.

I have an idea on how to easily do number 2: We need to have a Pull Request Template and if the user checked [X] for New extension, we ensure tests

@piv199
Copy link
Collaborator

piv199 commented Oct 7, 2016

My drafts

  • On added file count or check modifying pbproject file
  • Big PR, total lines out of 150-200 or more?
  • If sources modyfied and changed symbols more than x, change changelog, or check PR if its #trivial
  • swiftlint errors
  • Work in progress PR
  • forbid changing some files or include some text in PR if not a collaborator
  • if PR is not mergable, warn, but it may be obvious by github

@lfarah
Copy link
Collaborator Author

lfarah commented Oct 9, 2016

Danger Xcode Summary Plugin - A Danger plugin that shows all build errors, warnings and unit tests results generated from xcodebuild.

@piv199
Copy link
Collaborator

piv199 commented Nov 10, 2016

On weekend will add support for trivial change and related changes

@piv199 piv199 modified the milestone: 1.9 Dec 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants