Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Do not import NumPy functions directly #8

Open
rhiever opened this issue Dec 2, 2016 · 1 comment
Open

Refactor: Do not import NumPy functions directly #8

rhiever opened this issue Dec 2, 2016 · 1 comment
Labels
enhancement help wanted

Comments

@rhiever
Copy link
Contributor

rhiever commented Dec 2, 2016

We currently import several NumPy functions directly, e.g., here. Normally this isn't an issue, but min, max, mean, etc. override the standard definitions of these functions in Python.

We should refactor the code to import numpy as np then replace all of the NumPy function calls with np.<function name>.
@kymckay
Copy link

kymckay commented Oct 7, 2021

This appears to be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhiever @kymckay