Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level pack names are untranslatable #43

Open
gunchleoc opened this issue Aug 4, 2021 · 4 comments
Open

Level pack names are untranslatable #43

gunchleoc opened this issue Aug 4, 2021 · 4 comments

Comments

@gunchleoc
Copy link
Contributor

gunchleoc commented Aug 4, 2021

... or in need of xgettext & push to Transifex? My translation is at 100%.

enigma-levelpacks

When clicking on a level pack, the number of levels is in English:
enigma-levelpacks2

The window title is also untranslated, as well as +%d others
enigma-levelmenu

I also can't make my translation fit into that line. Smaller padding/margins might give us an extra line of text here.

Enigma version: 1.30 beta

@raoulb
Copy link
Contributor

raoulb commented Sep 5, 2021

Yes, it might be the case that some strings are not translatable, either for technical reasons or because the code is incomplete.
This would need further investigation to find the string in the source and see if they are all wrapped in the correct i18n function calls.

@raoulb
Copy link
Contributor

raoulb commented Sep 5, 2021

For example "Level Menu" here is not wrapped in an _ function call (GNU gettext):

set_caption(("Enigma - Level Menu"));

I do not know, why.

@gunchleoc
Copy link
Contributor Author

I managed to grep some:

src/gui/LevelPackConfig.cc:        set_caption(("Enigma - Level Pack Configuration"));
src/gui/LevelMenu.cc:        set_caption(("Enigma - Level Menu"));
src/gui/LevelPackConfig.cc:        Label * sokoballLabel = new Label("Sokoball:", HALIGN_RIGHT);
src/lev/RatingManager.cc:        return ecl::strf("%s+%d others", org.c_str(), others);

@raoulb
Copy link
Contributor

raoulb commented Mar 27, 2022

Some of the static strings should be fixed by PR #69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants