Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] More logical permission nodes #1190

Open
ESP4Ever opened this issue Apr 20, 2020 · 3 comments
Open

[Feature request] More logical permission nodes #1190

ESP4Ever opened this issue Apr 20, 2020 · 3 comments
Labels
status:pending Pending acceptance or closure. type:feature-request Request for something new version:five Issue related to CB5

Comments

@ESP4Ever
Copy link

ESP4Ever commented Apr 20, 2020

Hi and thank you for a such funny plugin!
I just started to use it and the first disadvantage i found is permissions.
F.e. craftbook.mech.bridge.use - if I'd like to give USE ALL mechanics permission to the player I need to create a huge list of craftbook.mech.XXXXX.use (craftbook.mech.[asterisk].use wildcard doesn't work)
Would it be possible to move mechanic's name to the end? In this case my task will be much easier - craftbook.mech.use.[asterisk]

@me4502
Copy link
Member

me4502 commented Apr 20, 2020

My main issue with this is that "use" is conceptually different between many of the mechanics, and allowing a blanket "use" permission would encourage people to not understand what they're giving their players the ability to do. Plus, many mechanics do not have a use permission, or have multiple permissions that make up the concept of usage.

As for craftbook.mech.[asterisk].use wildcard, wildcards are handled by the permissions plugin, not plugins that check for permissions. If you want wildcards within the middle of a permission node your permission plugin would need to support it.

@ESP4Ever
Copy link
Author

I'm using LuckPerms which is quite powerful but wildcards with asterisk in the middle don't work. Maybe I'm doing something wrong...

@me4502
Copy link
Member

me4502 commented Apr 20, 2020

I wasn't saying your permission plugin would support it, I was saying that it's up to the permissions plugin to support it

@me4502 me4502 added status:pending Pending acceptance or closure. type:feature-request Request for something new version:five Issue related to CB5 labels Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:pending Pending acceptance or closure. type:feature-request Request for something new version:five Issue related to CB5
Projects
None yet
Development

No branches or pull requests

2 participants