Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colons are removed from markup #129

Open
brendanlawton opened this issue Jul 5, 2017 · 3 comments
Open

Colons are removed from markup #129

brendanlawton opened this issue Jul 5, 2017 · 3 comments

Comments

@brendanlawton
Copy link

How to reproduce the error
Add a colon to a label for a form element e.g. Name:

Expected result
Colon shows up in widget admin field label

Actual result
Colon is removed

Notes
If you place multiple colons in the label the first one is removed and the rest are visible

@andrew-worsfold
Copy link
Contributor

@brendanlawton -

Just to clarify, is this native WordPress widget form label, or a control label for a Tailor element?

@brendanlawton
Copy link
Author

brendanlawton commented Jul 6, 2017

@andrew-worsfold it's a label for an input field in a twig file that is rendered as part of a custom WP_Widget. Here's an example:

<label for="{{ post.fieldId }}">{{ loop.index }}:</label>

// above example outputs the loop.index but no colon

@andrew-worsfold
Copy link
Contributor

@brendanlawton -

This was by design, in order to bring widget forms into line with default Tailor/Customizer controls. Could you provide an example that shows why it's important to leave the colon in place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants