Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arccore.filter bug in filter spec directive quanderscore parsing #2

Open
ChrisRus opened this issue Dec 20, 2021 · 0 comments
Open
Labels
bug Something isn't working error handling Handling / reporting of specific error(s)

Comments

@ChrisRus
Copy link
Member

re: @encapsule/arccore v0.1.6 "grasslands" https://www.npmjs.com/package/@encapsule/arccore

I was writing a large filter spec and noticed something odd in the way that filter parses filter spec directives (e.g. quanderscore-prefixed filter spec namespace descriptor object properties).

This is nonsense!

Error: Filter factory failure: While examining data namespace '~.outputFilterSpec.evalFrames.evalFrameDescriptor.frameEvalResults.frameEvalSummary.transitions.cdsDataPath': Unrecognized typemap directive '___________________________________________________whatever' not allowed in declaration.

I haven't looked at the code but am sure that I incorrectly determine that the property name starts with four underscores and then but neglected to account for some idiot (me - I found it) using more than four underscore.

This is very unlikely to impact very many people. However, filter should correctly parse quanderscore directives correctly to ensure that the FSP produces the correct error message in all cases.

@ChrisRus ChrisRus added bug Something isn't working error handling Handling / reporting of specific error(s) labels Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working error handling Handling / reporting of specific error(s)
Projects
None yet
Development

No branches or pull requests

1 participant