Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for a documentation of areaTop value #1417

Closed
sorenwacker opened this issue Oct 19, 2022 · 6 comments
Closed

Looking for a documentation of areaTop value #1417

sorenwacker opened this issue Oct 19, 2022 · 6 comments

Comments

@sorenwacker
Copy link

Hi,

I would like to know who El-Maven defines the AreaTop value. I looked in the documentation, but could not find that information.

@shubhra-agrawal
Copy link
Collaborator

AreaTop is the smoothened maxima of a peak. Mean value of the actual peak maxima and 1 neighbouring point on both sides of the maxima.

@sorenwacker
Copy link
Author

Thank you!

@sorenwacker
Copy link
Author

sorenwacker commented Dec 12, 2022

When I try to reproduce these values, I find this phenomenon:
image
It looks like El-maven applies baseline correction as well. Is the reason for this behaviour?
What you see here is the reimplementation of your areaTop score, but in some cases a constant value is removed for a set of files resulting in smaller values as compared to blindly applying the algorithm. Often the value is very similar for groups of files. Sometimes, there are multiple steps even for different groups of files.

@sorenwacker sorenwacker reopened this Dec 13, 2022
@sorenwacker
Copy link
Author

Actually, it only looks like a linear offset in log-scale. Linear it looks like this:
image

@sorenwacker
Copy link
Author

sorenwacker commented Dec 13, 2022

Do you have any idea where this discrepancy might come from? Is it a baseline correction? But why then this linear dependency on the areaTop value? It looks like El-Maven always divides by 3, even if there are only 2 or 1 datapoints in the extraction window.

@shubhra-agrawal
Copy link
Collaborator

Baseline correction happens before any peak detection in El-MAVEN. Just to correct for technical noise across samples.
We use a simple quantile method for baseline correction, where we smoothen the peak and set the baseline based on the user-set threshold.
PeakAreaTop by default shows the corrected intensity. There is another option for AreaTopNotCorrected that can be used to get the true PeakAreaTop value without the basline correction.

It looks like El-Maven always divides by 3, even if there are only 2 or 1 datapoints in the extraction window.
That might be a bug, will have to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants