Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misplaced string header causes failure during compilation #1415

Open
MetabolomicsAustralia-Bioinformatics opened this issue Jul 8, 2022 · 1 comment
Open

misplaced string header causes failure during compilation #1415

MetabolomicsAustralia-Bioinformatics opened this issue Jul 8, 2022 · 1 comment

Comments

@MetabolomicsAustralia-Bioinformatics
Copy link
Contributor

When compiling from the source code within the Linux Ubuntu environment by following the guideline on the front page, the fatal error has been triggered.

After a quick code review, the issue (and the solution) has been identified, where the root of the issue is because a string header has been misplaced.

Harry Wang
on behalf of Metabolomics Australia (VIC node), University of Melbourne

Error Capture
@MetabolomicsAustralia-Bioinformatics
Copy link
Contributor Author

The fix is really simple:
the string header within the 3rdparty/errorcodes.cpp needs to be moved into the 3rdparty/errorcodes.h

A pull request has been created to fix this issue

@MetabolomicsAustralia-Bioinformatics MetabolomicsAustralia-Bioinformatics changed the title misplaced string header within causes failure during compilation misplaced string header causes failure during compilation Jul 8, 2022
Merged
shubhra-agrawal added a commit that referenced this issue Jul 11, 2022
@shubhra-agrawal
Merge pull request #1416 from MetabolomicsAustralia-Bioinformatics/de…
3c07a9f 
…velop

Fix: misplaced string header causes failure during compilation issue #1415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MetabolomicsAustralia-Bioinformatics