Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support for Oxygen Labeling #1406

Open
mneinast opened this issue May 19, 2021 · 1 comment
Open

Feature Request: Support for Oxygen Labeling #1406

mneinast opened this issue May 19, 2021 · 1 comment

Comments

@mneinast
Copy link

Currently El-Maven supports labeling of Carbon, Hydrogen, Nitrogen, and Sulfur atoms. Please add support for labeling of Oxygen, specifically [18]-Oxygen which is the most common stable isotope used in experiments.

The additional mass in a single [18]-Oxygen is similar to the additional mass from two [13]-Carbons, but most experiments would not include both labeled oxygen and labeled carbon. In case this is a problem, I recommend a warning to the user that 18O might actually be two 13C.

@mneinast
Copy link
Author

mneinast commented Dec 3, 2022

@sakshikukreja14 has a branch https://github.com/ElucidataInc/ElMaven/tree/ftr_detect_oxygen_isotopes that adds this support for oxygen labeling. It works well besides one minor bug and a problem when building from source.

When building from source (in ubuntu on WSL), this error message appears:

string is not a member of std

#include <string> is missing in the file /ElMaven/3rdparty/ErrorHandling/errorcodes.h. Adding this line fixed the build error.

Once this build is launched, a black window appears overlaid in the middle of the screen. I think this is an error message. It can be removed by clicking Isotopes > selecting C13, and unselecting C13 again.

Thanks to @sakshikukreja14 again for putting this together - I have been using it frequently in the past few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant