Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ElmahCore.MsSql from System.Data.SqlClient to Microsoft.Data.SqlClient #157

Open
nathangreaves opened this issue Dec 6, 2022 · 1 comment · May be fixed by #163
Open

Migrate ElmahCore.MsSql from System.Data.SqlClient to Microsoft.Data.SqlClient #157

nathangreaves opened this issue Dec 6, 2022 · 1 comment · May be fixed by #163

Comments

@nathangreaves
Copy link

No new development is taking place in System.Data.SqlClient, and it is recommended to port to Microsoft.Data.SqlClient
See https://devblogs.microsoft.com/dotnet/introducing-the-new-microsoftdatasqlclient/

For ElmahCore library this should be a fairly simple case of changing the NuGet package from System.Data.SqlClient to Microsoft.Data.SqlClient
jafin added a commit to jafin/ElmahCore that referenced this issue Jan 17, 2023
@jafin
feat (SQLClient): Migrate to Migrate Microsoft.Data.SqlClient Resolves …
a537614 
…ElmahCore#157
@jafin jafin linked a pull request Jan 17, 2023 that will close this issue
Open
@georgefeakes
Copy link

Looks like until this is done .NET 8 won't be fully supported. I've experienced issues attempting to upgrade to .NET 8 while using ElmahCore due to the use of System.Data.SqlClient instead of Microsoft.Data.SqlClient. There is however a bug in Microsoft.Data.SqlClient which in order to fix requires the use of preview package 5.2.0-preview5.24024.3 - more can be seen here: dotnet/SqlClient#1930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat (SQLClient): Migrate to Migrate Microsoft.Data.SqlClient jafin/ElmahCore
2 participants
@georgefeakes @nathangreaves