Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct pkgconf #4924

Open
tmakar opened this issue May 13, 2023 · 4 comments
Open

Use correct pkgconf #4924

tmakar opened this issue May 13, 2023 · 4 comments
Labels

Comments

@tmakar
Copy link
Contributor

tmakar commented May 13, 2023

With this PR (#4895) we have introduced the go binding into our main repo. It seems that some of our distros use pkg-config but the newer version is pkgconf. pkg-config seems to not work when there are whitespaces in the ldflags or cflags. Therefore we changed the build directory name of jenkins to use no whitespaces.

As @kodebach wrote in Go to Repo PR it needs to be distinguished between distros and based on it choose correct pkg config. See Originally posted by @kodebach in #4895 (comment)

@tmakar tmakar changed the title Use correct pkg config Use correct pkgconf May 13, 2023
@markus2330
Copy link
Contributor

@tmakar can you please create a list in the top post on which distributions we have which problems? Maybe removing some old versions of some distros already solves the problem.

@kodebach
Copy link
Member

I originally thought OpenSUSE Leap doesn't ship a package for pkgconf. But that seems to be incorrect, there is a package, but I missed it.

However, we couldn't get Debian Stable working even with the pkgconf package in the PR, so this probably requires more debugging and error finding work.

AFAIK the main purpose of using "build directory" was finding error ins CMake and Shell scripts. For that purpose it might be enough to have a single build job that builds everything (all plugins, bindings, tools, etc. in shared, full and static) using "build directory" on a single distro where we know pkg-config works with spaces. The other jobs could just use a build dir without spaces.

@markus2330
Copy link
Contributor

AFAIK the main purpose of using "build directory" was finding error ins CMake and Shell scripts.

Yes, this is the main purpose (and probably the only purpose).

The other jobs could just use a build dir without spaces.

Originally it was implemented like this. I have no objections going back to that.

Copy link

I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@github-actions github-actions bot added the stale label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants