Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording for keyset and mountpoints #6

Open
lukashartl opened this issue May 11, 2022 · 1 comment
Open

Wording for keyset and mountpoints #6

lukashartl opened this issue May 11, 2022 · 1 comment

Comments

@lukashartl
Copy link
Collaborator

Consider the following task:

    - name: set some values
      elektra:
        mountpoint: 'system:/tests/hello'
        keys:
          hello: 123

This task does not mount anything, but the keyset is still named mountpoint, because the elektra module can be used for mounting and for setting.

  1. Should we rename it to keyset?
  2. Or should we split mount and set into separate modules?
@markus2330
Copy link
Collaborator

markus2330 commented May 12, 2022

Imho mountpoint should be renamed because it is not always a mountpoint. Possible alternatives are:

  • "parent" would be a neutral name (not claiming that it is a mountpoint)
  • "prefix" would be an alternative (libelektra-puppet used that name, imho it is a bit too generic and it is maybe not so clear that it refers to the name)
  • what about directly using the task name from Ansible? A further description could be added if someone wants to log further text during Ansible runs.

keys could be renamed to keyset to be more consistent with Elektra's terminology.

The other question, splitting into separate modules, is probably best answered while you implement the buildserver. If mounting directly with setting the keys is handy, we keep it as-is, if it disturbs we should change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants