Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

grid #680

Open
4 of 5 tasks
markus2330 opened this issue Jul 21, 2023 · 6 comments · May be fixed by #1183
Open
4 of 5 tasks

grid #680

markus2330 opened this issue Jul 21, 2023 · 6 comments · May be fixed by #1183
Assignees
Labels
enhancement New feature or request

Comments

@markus2330
Copy link
Contributor

markus2330 commented Jul 21, 2023

Tasks

  • (grid icon does not properly indicate if it is pressed)
  • use case does not have links etc.
  • 1m legend should be right bottom and being always fixed positioned
  • remove not needed svg
  • 0,0 should be specially marked (e.g. cross)

Use case

grid

Related Pull request

#524

@markus2330 markus2330 added enhancement New feature or request low priority labels Jul 21, 2023
@markus2330 markus2330 mentioned this issue Jul 21, 2023
19 tasks
@markus2330
Copy link
Contributor Author

"grid icon does not properly indicate if it is pressed" will probably be fixed by @tschawax but I think we don't have an issue for that yet?

@tschawax
Copy link
Contributor

"grid icon does not properly indicate if it is pressed" will probably be fixed by @tschawax but I think we don't have an issue for that yet?

Yes, this indicator thing would be covered by me. And correct, we don't have an issue for that yet.

@badnames
Copy link
Member

badnames commented Feb 9, 2024

1m legend should be right bottom

At the moment his might cause the legend to disappear, depending on the size of the browser window and the size of the left and right toolbars.
The reason for this is that our map area is not resized according to those values, overflowing areas are only hidden.

Fixing this would require me to redo the styling of the EditorMap component.
This might take me a long time since I don't know how this could be accomplished at the moment.

@badnames
Copy link
Member

badnames commented Feb 9, 2024

remove not needed svg

Which SVG are you talking about here?

@markus2330
Copy link
Contributor Author

At the moment his might cause the legend to disappear, depending on the size of the browser window and the size of the left and right toolbars.

The more important part is, that it stays fixed during panning. Does this work?

Which SVG are you talking about here?

The non-used one from https://github.com/ElektraInitiative/PermaplanT/pull/524/files (grid or grid-dots)

@badnames
Copy link
Member

badnames commented Feb 9, 2024

The more important part is, that it stays fixed during panning. Does this work?

I will push the fix shortly.

@badnames badnames linked a pull request Apr 3, 2024 that will close this issue
24 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Current Milestone
Development

Successfully merging a pull request may close this issue.

3 participants