Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working fine for me on php7, why was install blocked for php7? #45

Open
joschi127 opened this issue Dec 25, 2016 · 4 comments
Open

Working fine for me on php7, why was install blocked for php7? #45

joschi127 opened this issue Dec 25, 2016 · 4 comments

Comments

@joschi127
Copy link
Contributor

At least in our setup it is working as expected with php7 (using php 7.0.8), when reverting commit ID 63d3f7d (which will block install on php7).

What exactly is the problem with php7? Or was that issue solved in the meantime by the update of some other packages, like for example phpcr?

@joschi127
Copy link
Contributor Author

@bigfoot90 Do you remember what issues you had and why php7 was blocked?

@bigfoot90
Copy link
Contributor

Sorry, I don't remember exactly what was my issue at that time.
I was having throuble running tests on php7.
Can you run phpunit tests, are they ok?

@ElectricMaxxx
Copy link
Owner

ElectricMaxxx commented Jan 4, 2017 via email

@joschi127
Copy link
Contributor Author

Did not find the time to check if the tests of this repo are running successfully when executed locally on php7. But all our mapping which is done based on this bundle in our implementation is working fine.
When I find the time I will check the tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants