Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite_hanami in hanami 2.1 #446

Open
krzykamil opened this issue Mar 26, 2024 Discussed in #445 · 0 comments
Open

vite_hanami in hanami 2.1 #446

krzykamil opened this issue Mar 26, 2024 Discussed in #445 · 0 comments

Comments

@krzykamil
Copy link

Discussed in #445

Originally posted by krzykamil March 26, 2024
Hey

So currently the vite_hanami is broken to my understanding. It is probably meant for hanami pre 2.0, and now we have 2.1 which has its own, default way of doing views and assets.

However if someone wants to use hanami views, but not assets and wants to use vite, the current state of this gem, does not work for this purpose.

The tag helpers use non-existing methods, need to be included in a different way, in a different place, the vite-dev folder in public does not get generated etc.

In general for hanami, the gem is severely out-of-date. I was wondering if there are any plans/work in progress, to get it working again for hanami 2.1? If not, would you accept PR's that try to make it work with the newer hanami? It would be aimed for integrations that use hanami-views but skip hanami-assets I guess, although I am not sure. Without hanami-assets there are no tag halpers like javascript_tag etc. but everything else would be obsolete from that gem if using vite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant