Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert DeviceShifuBase data structure from single EdgeDevice to a list type of EdgeDevice #538

Open
kris21he opened this issue Mar 14, 2023 · 3 comments
Labels

Comments

@kris21he
Copy link
Contributor

Change EdgeDevice type from single type to array type, only support first item of config so not breaking current behavior.

Accept criteria:

  1. in examples/httpDeviceShifu/deployment/http-edgedevice.yaml, let's config as following
spec:
  -sku: "device1"
    connection: Ethernet
    address: 192.168.11.16:12345
    protocol: HTTP
  1. after this change, make shifu still working with following command
kubectl apply -f examples/httpDeviceShifu/deployment
  1. if there are multiple edgedevices in http_edgedevice.yaml file, always use the first one and ignore others
@kris21he kris21he changed the title In deviceShifuBase feature, convert it from single EdgeDevice to a list type of EdgeDevice convert DeviceShifuBase data structure from single EdgeDevice to a list type of EdgeDevice Mar 15, 2023
@SuperAayush
Copy link
Contributor

Hey @kris21he, I would like to work on this!!

@tomqin93
Copy link
Contributor

Hi @SuperAayush , thank you so much!
I will assign this issue to you. If you ever need anything, feel free to reach out to us, my e-mail address is xqin@edgenesis.com

@kris21he
Copy link
Contributor Author

@SuperAayush I am so glad that you picked this up, any questions free free to let us know.
Looking forward to your ideas, thoughts, and PR for this.
Thank you for your enthusiasm of contributing to the shifu community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants