Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorlcd - add us as a PPM Unit option #4977

Open
1 task done
pfeerick opened this issue May 7, 2024 · 3 comments · May be fixed by #4987
Open
1 task done

Colorlcd - add us as a PPM Unit option #4977

pfeerick opened this issue May 7, 2024 · 3 comments · May be fixed by #4987
Labels
color Related generally to color LCD radios enhancement ✨ New feature or request UX-UI Related to user experience (UX) or user interface (UI) behaviour

Comments

@pfeerick
Copy link
Member

pfeerick commented May 7, 2024

Is there an existing issue for this feature request?

  • I have searched the existing issues

Is your feature request related to a problem?

In #3163, it was noted that -DPPM_UNIT_US did not work on colorlcd, i.e. changing display and inputs from % to us, as well as asking if it could be made so that it was not something required a custom build. #3993 addressed the latter point, but the "PPM Units" runtime entry only gives options of 0.0 and 0.-- on colorlcd - which correctly reflects the units supported on the colorlcd UI at present.

Describe the solution you'd like

That a third option be added, which allows for units to be displayed as us where they are currently shown only as %, as well as for relevant edit fields to change from % to us input. i.e. so it matches the B&W level of support.

Describe alternatives you've considered

Digging out my old slide rule

Additional context

No response

@pfeerick pfeerick added enhancement ✨ New feature or request color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour labels May 7, 2024
@sande005
Copy link

sande005 commented May 7, 2024

FWIW - all three option are available in Companion, and work correctly. But after download to radio (Frsky X10S-E Access) all revert to the default. As noted "us" option is not listed on the radio.

@xros
Copy link

xros commented May 24, 2024

same issue on 2.9.4 (self-compiled with -DPPM_UNIT_US) too.
v2.10.0 has PPM Unit US option in the radio. Maybe flash it and try.

@pfeerick
Copy link
Member Author

us units was never fully implemented on colorlcd anyway as part of the colorlcd rewrite from opentx 2.4, but #4987 for colorlcd side should finally implement that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Related generally to color LCD radios enhancement ✨ New feature or request UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants