Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling both internal and external ELRS should be usable or impossible #4937

Open
1 task done
wimalopaan opened this issue Apr 28, 2024 · 4 comments
Open
1 task done
Labels
bug 🪲 Something isn't working known issue Issues that are related to upstream bugs or external to the project telemetry 📶

Comments

@wimalopaan
Copy link
Contributor

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

Oviously ETX is not designed to use two ELRS modules anabled at the same time. Telemetry -> "Start search sensors" completely hangs the radio (need to disconnect the battery).

Expected Behavior

It is possible to physically have two ELRS modules in one radio: internal and external.

Either:

a) If one of the modules is enabled, keep the other disabled

b) allow that both are enabled, and then use them in the expected behaviour. This includes telemetry (EdgeTx then has to process two telemetry streams) and the elrsV3.lua, which needs to choose between the two.

Steps To Reproduce

  1. Enable both modules for a specific model
  2. In "Telemetry" start "Search sensors"
  3. the radio freezes.

Version

Other (Please specify below)

Transmitter

FrSky X12

Operating System (OS)

Linux

OS Version

Arch Linux

Anything else?

No response

@wimalopaan wimalopaan added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Apr 28, 2024
@pfeerick
Copy link
Member

pfeerick commented Apr 29, 2024

Didn't know it would make it crash, but unexpected/indeterminate behaviour was expected, but is probably only documented deep in some telemetry related issues where telemetry needs to be overhauled to allow for seperate streams for multiple modules. Disabling both is not really an option even know, as you can use both (i.e. for dual independent Rx , or dual frequency), just can't manage telemetry or Lua with both connected at the same time. Similar to using multiple rxs with a single tx for extra channels, maybe disabling telemetry on second tx/rx pipelinemay help here.

@pfeerick pfeerick added known issue Issues that are related to upstream bugs or external to the project telemetry 📶 and removed triage Bug report awaiting review / sorting labels Apr 29, 2024
@wimalopaan
Copy link
Contributor Author

Updating the internal and the external ELRS module to 3.3.4-RCx fixed the freeze problem.

@raphaelcoeffic
Copy link
Member

It shouldn't be missing much, as most things are already separate.

@wimalopaan
Copy link
Contributor Author

Well, I don't know, what the problems with the actual implementation is, so I can't imagine to nearby solution. I do not even know for sure if this is also true for the MPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working known issue Issues that are related to upstream bugs or external to the project telemetry 📶
Projects
None yet
Development

No branches or pull requests

3 participants