Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

joystick Middle(zero) position is not precise zero #4881

Open
1 task done
ThomasKuehne opened this issue Apr 15, 2024 · 0 comments · May be fixed by #4883
Open
1 task done

joystick Middle(zero) position is not precise zero #4881

ThomasKuehne opened this issue Apr 15, 2024 · 0 comments · May be fixed by #4883
Labels
bug 🪲 Something isn't working triage Bug report awaiting review / sorting

Comments

@ThomasKuehne
Copy link
Contributor

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

The center position reported for analog joystick axis the PC is constant but not precipice 0.

This is true for actual axis input, three state switches and even input sources with input weight 0.

Tested with:
https://hardwaretester.com/gamepad

Expected Behavior

Analog joystick axis report 0 input as 0 output.

Steps To Reproduce

  1. configure a mixer with any input source and a weight of 0.
  2. plugin to PC in USB mode
  3. check reported values - e.g. with https://hardwaretester.com/gamepad

Version

Nightly (Please give date/commit below)

Transmitter

Jumper T-Lite

Operating System (OS)

No response

OS Version

No response

Anything else?

Some game APIs perform on-PC filtering, rounding and apply dead zones that may hide the issue.
@ThomasKuehne ThomasKuehne added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Apr 15, 2024
ThomasKuehne added a commit to ThomasKuehne/edgetx that referenced this issue Apr 15, 2024
@ThomasKuehne
fix(radio) properly center analog joystick axis
ef42020 
Analog joystick axis are encoded as unsigned integers ranging
[0 - 2047]. As a consequence input value 0 is reported as output
1024. This leads to asymmetric output:
1024 values smaller than 0 and 1023 values larger than 0.

Fix EdgeTX#4881 by changing the range from [0 - 2027] to
[0 - 2026]. As a consequence inputs -1024 and -1023 are both encoded
as the same output 0.
@ThomasKuehne ThomasKuehne linked a pull request Apr 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🪲 Something isn't working triage Bug report awaiting review / sorting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(radio): properly center analog USB joystick axis ThomasKuehne/edgetx
1 participant
@ThomasKuehne