Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent dots from displaying at all? #8

Open
TheGeekPharaoh opened this issue Jul 9, 2014 · 7 comments
Open

Prevent dots from displaying at all? #8

TheGeekPharaoh opened this issue Jul 9, 2014 · 7 comments

Comments

@TheGeekPharaoh
Copy link

I'm have a use case where we are not allowing any actions at all on photos being displayed in EBPhotoPages. We've disabled them all via the EBPhotoPagesDataSource instance, but the "..." button is still being displayed in the toolbar, even though there are no associated actions. Is there any way to prevent the dots from being shown in the first place? A button with no actions associated with it provides a poor user experience.

@EddyBorja
Copy link
Owner

Yes, make sure your data source always returns NO for this method

- (BOOL)photoPagesController:(EBPhotoPagesController *)photoPagesController shouldAllowMiscActionsForPhotoAtIndex:(NSInteger)index;

If it still appears this may be a bug.

@TheGeekPharaoh
Copy link
Author

I am returning NO, but I still see the button at the bottom of the screen. It doesn't do anything, but it's still there.

@EddyBorja
Copy link
Owner

And you're using the latest version of PhotoPages? This feature was added
later.

On Wednesday, July 9, 2014, sdnakhla notifications@github.com wrote:

I am returning NO, but I still see the button at the bottom of the screen.
It doesn't do anything, but it's still there.


Reply to this email directly or view it on GitHub
#8 (comment)
.

@TheGeekPharaoh
Copy link
Author

I'm using 0.9.1 via CocoaPods.  Is there a more recent version I should upgrade to?

On Wednesday, July 9, 2014 1:41 PM, Eddy Borja notifications@github.com wrote:

And you're using the latest version of PhotoPages? This feature was added
later.

On Wednesday, July 9, 2014, sdnakhla notifications@github.com wrote:

I am returning NO, but I still see the button at the bottom of the screen.
It doesn't do anything, but it's still there.


Reply to this email directly or view it on GitHub
#8 (comment)
.


Reply to this email directly or view it on GitHub.

@EddyBorja
Copy link
Owner

Yea there have been 10 commits since 0.9.1, the podspec has to be updated. I wish there was an auto-updating script for podspecs.

@TheGeekPharaoh
Copy link
Author

Will you be updating the pod spec any time soon? Or will I have to build it manually to get the latest commits?

@EddyBorja
Copy link
Owner

I'm buried in work right now so I don't have time, but maybe I'll get to it
in a few days.

On Mon, Aug 4, 2014 at 11:38 AM, sdnakhla notifications@github.com wrote:

Will you be updating the pod spec any time soon? Or will I have to build
it manually to get the latest commits?


Reply to this email directly or view it on GitHub
#8 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants