Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow the word invalid for clearer error descriptions #751

Closed
wants to merge 1 commit into from
Closed

feat: allow the word invalid for clearer error descriptions #751

wants to merge 1 commit into from

Conversation

christophermorin
Copy link

@christophermorin christophermorin commented Sep 1, 2022 •
edited

Fixes Issue

Closes #748

Changes proposed

Allows the word 'invalid' to be used.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Please ignore if changing the banned words list is frowned upon. This seemed like an easier issue for a beginner so I had a crack at it.

@loftwah
Copy link
Member

loftwah commented Nov 17, 2022

This looks good to me, although it isn't apparent why there are two lists of words. What is the difference between line 8 and line 13?

For example, fellow is found in both of them.

@christophermorin christophermorin closed this by deleting the head repository Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow the word invalid
2 participants
@christophermorin @loftwah