fix: Escape pipes. It makes wrong render as tables in Kramdown/GFM engines #6723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search using regexp: (?<!\\)\| Via EbookFoundation#5176
This was referenced Feb 14, 2022
davorpa
added a commit
to AgilAghamirzayev/free-programming-books
that referenced
this pull request
Jul 24, 2022
eshellman
pushed a commit
that referenced
this pull request
Jul 25, 2022
* Update free-courses-en.md * format: Remove video timing param from ulrs and escape pipes from titles Addresses #6723 * format: escape markdown tokens from resource title Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve repo
For resources
Description
GitHub Pages is a bit tricky. Pipes
|make wrong render as tables using any Kramdown/GFM ruby engines, independenly if is present inside link or it hasn't table header syntax.Replacement using regexp search:
(?<!\\)\|Why is this valuable (or not)?
This PR delve with it until up to date but linter needs be replugged in to definitelly solve #5176
Checklist:
Follow-up