Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Error causing future PR's to fail Travis CI build #4606

Closed
kadhirash opened this issue Oct 22, 2020 · 1 comment
Closed

Merge Error causing future PR's to fail Travis CI build #4606

kadhirash opened this issue Oct 22, 2020 · 1 comment

Comments

@kadhirash
Copy link
Member

kadhirash commented Oct 22, 2020

I noticed that some people's recent PR's are failing.
Listed some for reference:

When trying to look at the Travis CI build for why, it mentions another file as the root problem.

Issues are:

  1. Missing new line at the end of file
  2. Many Incorrect number of blank lines
  3. Alphabetical ordering

Some of the titles are in Farsi, so it makes it difficult for someone that doesn't know Farsi to alphabetize titles properly.

Tracing where this might have happened, I think it might be #4593 where this started?

@eshellman @SethiPandi what do you guys think?

@kadhirash
Copy link
Member Author

I can try to work on this later so future PR's can pass the build check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant