Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Refactor - HTML Strings in JS Files #465

Open
7 tasks
gokulprathin8 opened this issue Mar 5, 2024 · 0 comments
Open
7 tasks

Code Refactor - HTML Strings in JS Files #465

gokulprathin8 opened this issue Mar 5, 2024 · 0 comments
Labels
enhancement New feature or request HTML java Pull requests that update Java code Javascript Refactor Templating Engine

Comments

@gokulprathin8
Copy link
Collaborator

gokulprathin8 commented Mar 5, 2024

What is this PR about?

Move all HTML strings in JavaScript files to a separate HTML file with a templating library for better management and less confusion.

Some of the files that needs to be refactored are:

  • gw.workflow.js
  • gw.ssh.js
  • gw.host.js
  • gw.menu.js
  • gw.process.js
  • gw.user.js
  • gw.workspace.js

There might be more files, please add them here if you think the list is incomplete.

What needs to be done?

  • Refactor existing JavaScript code to remove inline HTML strings.
  • Organize HTML content into template files using Thymeleaf, ensuring that dynamic content is properly managed through Thymeleaf's syntax.
  • Test the refactored code extensively to ensure that the UI rendering behaves as expected without regressions.

P.S application.properties already has thyme-leaf configured, we just need to use it.

Expected Outcome

JS and HTML are sperated to a good extent. Making it easy to build features on top of existing codebase easy and efficient.

@srilathamaddineni srilathamaddineni self-assigned this Mar 5, 2024
@gokulprathin8 gokulprathin8 added java Pull requests that update Java code Javascript HTML Templating Engine enhancement New feature or request Refactor labels Mar 9, 2024
@manasa123104 manasa123104 removed their assignment May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request HTML java Pull requests that update Java code Javascript Refactor Templating Engine
Projects
None yet
Development

No branches or pull requests

3 participants