Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness to crop growing seasons longer than 365 days #2521

Open
samsrabin opened this issue May 3, 2024 · 0 comments
Open

Improve robustness to crop growing seasons longer than 365 days #2521

samsrabin opened this issue May 3, 2024 · 0 comments
Assignees
Labels
priority: low Background task that doesn't need to be done right away. type: -investigation Needs to be verified and more investigation into what's going on.

Comments

@samsrabin
Copy link
Contributor

I found an old task in my to-do list that I've unfortunately lost the context for:

Where all does code assume growing seasons < 365 days? Is it just in idpp calculation?

This is only possible with mxmat = .false. for now, which is not something people should normally run with. Even then, I'm not sure there aren't guardrails to force a harvest at day 364. I'm thus marking this as low-priority. However, it might have implications for the fruit tree PR (#1966).

@samsrabin samsrabin added priority: low Background task that doesn't need to be done right away. type: -investigation Needs to be verified and more investigation into what's going on. labels May 3, 2024
@samsrabin samsrabin self-assigned this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Background task that doesn't need to be done right away. type: -investigation Needs to be verified and more investigation into what's going on.
Projects
None yet
Development

No branches or pull requests

1 participant