Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clm6_0 defaults #2501

Merged
merged 34 commits into from May 13, 2024
Merged

Fix clm6_0 defaults #2501

merged 34 commits into from May 13, 2024

Conversation

ekluzek
Copy link
Contributor

@ekluzek ekluzek commented Apr 30, 2024

Description of changes

Fix namelist defaults for clm6_0 brought in with ctsm5.2.0 as identified in #2492

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):
Fixes #2492
Fixes #2504
Fixes #2519
Fixes #2520
One tick box in #2403

Are answers expected to change (and if so in what way)? Yes! (only for clm6_0 physics though)

Any User Interface Changes (namelist or namelist defaults changes)?
snicar_snobc_intmix, snow_thermal_cond_method, and irrigate
fix use_cases for clm6_0

Testing performed, if any: namelist testing, regular and ctsm_sci test lists

@ekluzek ekluzek added the type: enhancement new capability or improved behavior of existing capability label Apr 30, 2024
@ekluzek ekluzek added this to the cesm2_3_beta17 milestone Apr 30, 2024
@ekluzek ekluzek self-assigned this Apr 30, 2024
@ekluzek
Copy link
Contributor Author

ekluzek commented Apr 30, 2024

In CSEG we decided this is OK to bring in for cesm2_3_beta18 since the CESM coupled compsets use clm5_1.

@wwieder
Copy link
Contributor

wwieder commented Apr 30, 2024

I'm a little confused by this last comment. Why is CESM using clm5_1 physics? I thought the whole reason for delaying the alpha17 tag was to get 5.2 datasets onto main to avoid all the source mods and workarounds needed to run a 5.2 dataset with 5.1 physics?

Regardless, will the beta17 tag have dead arctic veg modifications active?

@ekluzek
Copy link
Contributor Author

ekluzek commented May 1, 2024

@wwieder this is all something we'll discuss more in depth as a group tomorrow. Yes, I did the update to clm6_0 in ctsm5.2.0 and it naturally fits there -- but was it required and the best time to do it? This will come up in the future so learning here can help us down the road.

At ctsm5.2.0 clm5_1 becomes deprecated (see #2379), misnamed, and misleading. A natural thing to think is that clm5_1 would use the clm5_1 surface datasets while clm6_0 uses the newer ones. So at ctsm5.2.0 I removed almost all of the "I compset" Clm51 compsets, and changed all the testing to Clm60. You can still use clm5_1 with long name compsets for "I cases" though.

At ctsm5.2.0 it becomes a project for CESM to remove uses of CLM51 in compsets and tests. As you can see from #2379 it will take a while for this to go through CESM. Changes in CESM across components take awhile to happen by nature.

But, ctsm5.2.0 is correct when clm5_1 in terms of use of the dead-veg. So the current CAM and CESM compsets will be fine. And that's what will be used for the coupled model testing. Part of what we were looking for on Tuesday at CSEG was to NOT require a tag that was absolutely required for cesm2_3_beta17. This still might make it in though...

@ekluzek ekluzek added the tag: next this issue should get some attention in the next week or two label May 2, 2024
…clm5_1 and clm6_0 physics options is only the params_file which is what's expected this finishes out issues in ESCOMP#2492
@ekluzek ekluzek modified the milestones: cesm2_3_beta18, cesm2_3_beta17 May 6, 2024
Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekluzek thank you for showing me the work that went into this PR.

CTSM5.2 1979 fsurdat and 1979-2026 landuse ne0np4 files + two fixes

Includes work by multiple people:
@slevis-lmwg: new fsurdat/landuse files and corresponding infrastructure for
the three so-called VR grids (ne0np4)
@samsrabin: a subset_data fix
@olyson: corrections to a couple of history long-names and updates to
history_fields_fates.rst and history_fields_nofates.rst
@ekluzek ekluzek removed the tag: next this issue should get some attention in the next week or two label May 13, 2024
…o match how the finidat matching is done so that it now works
@slevis-lmwg
Copy link
Contributor

Summary of aux_clm on izumi...
Ok except that this test failed on setup before including the last commit:
SMS_Ly5_Mmpi-serial.1x1_smallvilleIA.IHistClm60BgcCropQianRs.izumi_gnu.clm-gregorian_cropMonthOutput
The last commit fixed it.

@ekluzek ekluzek merged commit 75b34d2 into ESCOMP:master May 13, 2024
2 checks passed
@ekluzek ekluzek deleted the fixclm50defaults branch May 13, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement new capability or improved behavior of existing capability
Projects
Status: Done
3 participants