Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESAPI excludes transitive dependency xalan from xom, but does not include it itself #795

Open
in-fke opened this issue Aug 14, 2023 · 2 comments
Labels

Comments

@in-fke
Copy link

in-fke commented Aug 14, 2023

Describe the bug
ESAPI excludes transitive dependency xalan from xom, but does not include it itself
see
https://github.com/ESAPI/esapi-java-legacy/blob/develop/pom.xml#L181C22-L181C73
it states

excluded because we directly import newer versions

Specify what ESAPI version(s) you are experiencing this bug in
2.5.2.0

To Reproduce
run mvn dependency:tree

Expected behavior
Expected to directly depend on xalan:xalan:2.7.3 (no need to exclude it, just explicitly add the dependency to raise the version)

@in-fke in-fke added the bug label Aug 14, 2023
@kwwall
Copy link
Contributor

kwwall commented Aug 14, 2023

IIRC, the reason we excluded xalan in the first place was that had a log of unpatched known vulnerabilities and we didn't rely on any functionality in xom that used anything from xalan.

We are currently using xom:xom:1.3.8, but I just updated our pom to 1.3.9, which no longer has a dependency on xalan, so I simply removed that exclusion as well. It will be out in our next release. Thanks.

@in-fke
Copy link
Author

in-fke commented Aug 14, 2023

Ok, great, that's even better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants