Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake config tests FAST_BUILD variable #1715

Closed
discopt opened this issue Apr 4, 2024 · 1 comment
Closed

cmake config tests FAST_BUILD variable #1715

discopt opened this issue Apr 4, 2024 · 1 comment
Assignees
Labels

Comments

@discopt
Copy link

discopt commented Apr 4, 2024

The generated (and installed) highs-config.make file contains a test

if (FAST_BUILD)
  if(NOT TARGET highs)
    include("${CMAKE_CURRENT_LIST_DIR}/highs-targets.cmake")
  endif()
  set(HIGHS_LIBRARIES highs)
else()
  if(NOT TARGET libhighs)
    include("${CMAKE_CURRENT_LIST_DIR}/highs-targets.cmake")
  endif()
  set(HIGHS_LIBRARIES highs)
endif()

This file is included from cmake projects that use HiGHS. So they typically don't have a FAST_BUILD variable. Even if they have one, it may be different from the value that this variable had when building HiGHS. I don't know exactly what the difference between FAST_BUILD and non-FAST_BUILD is, but I guess the intended behavior would be to have @FAST_BUILD@ in the if-statement.

@galabovaa
Copy link
Contributor

Thank you! We intend to remove FAST_BUILD but until then I have added your suggestion in #1744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants