Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace broken link with suggested one #135

Closed
wants to merge 1 commit into from
Closed

chore: replace broken link with suggested one #135

wants to merge 1 commit into from

Conversation

dextrot
Copy link

@dextrot dextrot commented Feb 24, 2024

Description

This PR fixes #132

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@dextrot
chore: replace broken link with suggested one
2731ac2 
Signed-off-by: dextrot <131444479+dextrot@users.noreply.github.com>
@dextrot
Copy link
Author

dextrot commented Feb 24, 2024

@geofrizz @ChrisJohnNOAA I raised this pull request updating the link. Please let me know if I should make any further changes, here.

Thank you.

@ChrisJohnNOAA
Copy link
Contributor

@geofrizz @ChrisJohnNOAA I raised this pull request updating the link. Please let me know if I should make any further changes, here.

Thank you.

I'm not sure that is the correct link. Part of the task is making sure the link is correct. Bob has a comment on the issue about where might be a good place to look.

@dextrot
Copy link
Author

dextrot commented Feb 26, 2024

@geofrizz @ChrisJohnNOAA I raised this pull request updating the link. Please let me know if I should make any further changes, here.
Thank you.

I'm not sure that is the correct link. Part of the task is making sure the link is correct. Bob has a comment on the issue about where might be a good place to look.

Thank you, will investigate the correct link.

ChrisJohnNOAA
ChrisJohnNOAA requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@ChrisJohnNOAA ChrisJohnNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

officially marking as changes requested for getting a better link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJohnNOAA ChrisJohnNOAA ChrisJohnNOAA requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong link in the iso19115.xml metadata extraction !
2 participants
@dextrot @ChrisJohnNOAA