Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV response object #136

Open
Gyukat opened this issue Apr 9, 2018 · 2 comments
Open

CSV response object #136

Gyukat opened this issue Apr 9, 2018 · 2 comments

Comments

@Gyukat
Copy link

Gyukat commented Apr 9, 2018

CSV response object should be a simple summary email with an attached CSV file, including DEQAR Report IDs, DEQARINST and ETER IDs, warnings for non-valid objects with applicable fields highlights, remarks for flags with applicable fields highlighted

@Gyukat
Copy link
Author

Gyukat commented Apr 9, 2018

Discussion:
Not enough information at the top. No way to see overview of submission success.
Suggested Summary
-Total number of reports submitted:
--Total accepted:
--Total rejected:
-Total number of institution records identified or created:
--Total existing institution records identified:
--Total new institution records created:
-Total number of sanity check warnings:
--# warnings on # reports <<< is a warning counted as a flag or as a record status?
--Total high level flags: # flags on # reports
--Total low level flags: # flags on # reports

Record Listing | Naming of report confusing, labels could be ordered more logically, including new institution records higher. Labels for specific problems should not appear if there are no problems.

-Report Name needs to be contextualised for different environments, in this case: [agency_esg_activities.activity] “ (on ” [institutions.name_primary]“)” for multiple institutions put all (?) separated by ", "After Report Identifier put:“Insitution record(s): ” [institutions.name_primary] “ (DEQARINST[institutions.deqar_id]) ” followed by “new record!” if the institution record is new. For multiple institutions put "; " and continue list.Next put “Sanity check status: ” then “Assigned flag: ”.

Colin mentioned that we should combine these two, under "Sanity check status:" I would also consider moving this up above institutions to make the list more compact. Then space, then “Problem(s) identified with submitted report data:” then new line with list of problems, then two new lines, then “Problem(s) identified with submitted institution data:” then new line with list of problems, then two new lines. These two labels should not stay if there is no data underneath! Are we keeping the "Problems identified with submitted institution data:"?

Report - SPACE Programme Accreditation (on University of Ljubliana)
DEQAR report identifier assigned: 179
Institution record: University of Ljubljana (DEQARINST2799) new record!
Sanity check status: warning (high level)
Assigned flag: high level
Problems identified with submitted report data:....
Problems identified with submitted institution data:.....

OR

Report - SPACE Programme Accreditation (on University of Ljubliana)
DEQAR report identifier assigned: 179
Sanity check status: warning (high level)
Problems identified with submitted report data:....
Institution record: *University of Ljubljana (DEQARINST2799) new record!
Problems identified with submitted institution data:.....

OR

Report - SPACE Programme Accreditation (on University of Ljubliana)
DEQAR report identifier assigned: 179
Sanity check status: warning (high level)
Institution record: *University of Ljubljana (DEQARINST2799) new record!
Problems identified with submitted report data:....
Problems identified message

@Gyukat
Copy link
Author

Gyukat commented May 3, 2018

We would need to work on having an attached CSV file including the results (Report IDs, DEQARINST IDs, ETER IDs, validation errors and flags)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant