Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about #2

Open
cherakhan opened this issue Jun 7, 2018 · 4 comments
Open

Question about #2

cherakhan opened this issue Jun 7, 2018 · 4 comments

Comments

@cherakhan
Copy link

cherakhan commented Jun 7, 2018

Hi

I have run the matTFA for 'GSmodel_Ecoli.mat'. It fails because of infeasibility. I was wondering if the codes works fine on your systems? if not, please let me know what might be the cause of this error?

Thank you

Relaxation of DGo_MECDPS : 28.391 +- 2.256 (sigma) ---> 28.391 +- 72.256
Relaxation of DGo_REPHACCOAI : 16.774 +- 4.121 (sigma) ---> 16.774 +- 2
4.121
It was not possible to obtain TFA-feasible solutions with the original DGo values calculated by GCM!
We had to relax the following DGo ranges as follows:

ans =

'varName'           'LB-before'    'UB-before'    'LB-relaxed'    'UB-relaxed'
'DGo_MECDPS'        [  26.1357]    [  30.6469]    [   12.6021]    [   44.1805]
'DGo_REPHACCOAI'    [  12.6529]    [  20.8957]    [    8.5316]    [   25.0171]

Error using relaxModelWithDGoSlacks (line 171)
Although we relaxed the DGo variables it was not possible to find a feasible solution!

Error in convToTFA (line 645)
[model, relaxedDGoVarsValues, modelwDGoSlackVars] = relaxModelWithDGoSlacks(model, minObjSolVal,
rxnNameListNoDGoRelax);

Error in tutorial_GEM (line 53)
tmp = convToTFA(prepped_m,ReactionDB,[],'DGo');

@psalvy
Copy link
Member

psalvy commented Jun 7, 2018

Hi @cherakhan,

I am assuming you are using tutorial_GEM.m ?
Could you please check that the code runs fine if you replace

tmp = convToTFA(prepped_m,ReactionDB,[],'DGo');

by

min_obj = solFBA.f*0.95;
tmp = convToTFA(prepped_m,ReactionDB,[],'DGo', [], min_obj);

Let me know how it goes :)

@psalvy
Copy link
Member

psalvy commented Jun 7, 2018

Ok. I was able to reproduce your error.
I am pretty sure the issue is that the value of minObjSolVal (1e-6) for validation of the relaxation in convToTFA and relaxModelWithDGoSlacks is below the tolerance of the solver for optimality. I changed its default to 1e-5 and it seems to work.

I will push on the dev branch, and once you have confirmed it works for you too, I will merge to master

@cherakhan
Copy link
Author

cherakhan commented Jun 7, 2018

Hi,

Many thanks for your response. The issue was resolved according to your modification.

BUT, the another error is coming from undefined "solveCobraLP_edited" function from "solveFBAmodelCplex" in "runMinMax". I can not find "solveCobraLP_edited" !

Thank you very much

@psalvy
Copy link
Member

psalvy commented Jun 8, 2018

Hi,

If I am not mistaken, solveCobraLP_edited is in the same file as solveFBAmodelCplex, L128

Cheers,

Pierre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants