Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent code block creation when using markdown in slot #706

Open
silvester-pari opened this issue Mar 4, 2024 · 1 comment
Open

Prevent code block creation when using markdown in slot #706

silvester-pari opened this issue Mar 4, 2024 · 1 comment
Labels
bug Something isn't working storytelling waiting Waiting for some kind of external things to happen

Comments

@silvester-pari
Copy link
Collaborator

When using markdown inside the slot, it happen easily that the indentation causes the creation of code blocks:

<eox-storytelling>
This creates a paragraph
</eox-storytelling>

    <eox-storytelling>
    This creates a code block
    </eox-storytelling>

This is because of the "indented code block" commonmark spec.

There is a way to disable this rule in markdown-it, which we probably should do for the slot-passed markdown by default.

@silvester-pari silvester-pari added bug Something isn't working storytelling labels Mar 4, 2024
@silvester-pari
Copy link
Collaborator Author

When disabling the code rule in markdown-it, there is an issue since everything renders as a paragraph instead. I consider it a bug and opened an issue: markdown-it/markdown-it#1014

@silvester-pari silvester-pari added the waiting Waiting for some kind of external things to happen label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working storytelling waiting Waiting for some kind of external things to happen
Projects
None yet
Development

No branches or pull requests

1 participant