Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that OPTIONS returns reasonable content #45

Open
matthewdarwin opened this issue Aug 1, 2019 · 1 comment
Open

check that OPTIONS returns reasonable content #45

matthewdarwin opened this issue Aug 1, 2019 · 1 comment
Assignees
Labels
check enhancement New feature or request

Comments

@matthewdarwin
Copy link
Contributor

curl -i -X OPTIONS http://jungle.eosn.io/v1/chain/get_info
HTTP/1.1 204 No Content
Server: nginx/1.14.2
Date: Thu, 01 Aug 2019 00:04:39 GMT
Connection: keep-alive
Access-Control-Allow-Origin: *
Access-Control-Allow-Methods: GET, POST, HEAD, OPTIONS
Access-Control-Allow-Headers: Origin, X-Requested-With, Content-Type, Accept
Access-Control-Max-Age: 1728000
Content-Type: text/plain; charset=utf-8
Content-Length: 0

@matthewdarwin matthewdarwin added enhancement New feature or request check labels Aug 1, 2019
@matthewdarwin matthewdarwin self-assigned this Sep 17, 2019
@fabian-emilius
Copy link

Currently the validator checks for the Access-Control-Allow-Headers header in the normal response but this header should be only available in the preflight (OPTIONS) response.
Popular libraries like cors for example only include it in the OPTIONS request https://github.com/expressjs/cors/blob/c49ca10e92ac07f98a3b06783d3e6ba0ea5b70c7/lib/index.js#L168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants