Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement exception handling filter #9

Open
AshrafAlam opened this issue Apr 5, 2019 · 4 comments
Open

implement exception handling filter #9

AshrafAlam opened this issue Apr 5, 2019 · 4 comments
Labels
first-timers-only good first issue Good for newcomers
Projects
EISK Board (main)

Comments

@AshrafAlam
Copy link
Member

AshrafAlam commented Apr 5, 2019 •
edited

The filter should do the following:

  • return json formatted response. (reference 1, reference 2)
  • (optional) convert the underlying system exception message to a generic user friendly message
  • (optional) using .net core build in log class to log the details of the exception.
@AshrafAlam AshrafAlam created this issue from a note in EISK Board (main) (Ready) Apr 5, 2019
@CyberZujo
Copy link

I would like to take this issue

@AshrafAlam
Copy link
Member Author

AshrafAlam commented May 16, 2019 •
edited

@CyberZujo thanks for your interest. Please check the updated details of the issue and then proceed to the implementation and make a pull request.

Cheers!

@AshrafAlam AshrafAlam added the good first issue Good for newcomers label Jul 19, 2019
@AshrafAlam AshrafAlam mentioned this issue Jun 10, 2022
Open
@AshrafAlam AshrafAlam moved this from Ready to In progress in EISK Board (main) Jun 10, 2022
@AshrafAlam
Copy link
Member Author

Before implementation, please discuss how you want to implement (with sample code if possible).

@AshrafAlam AshrafAlam pinned this issue Jun 10, 2022
@T-450
Copy link

T-450 commented Jun 25, 2022

Sent the PR with the design and implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
first-timers-only good first issue Good for newcomers
Projects
EISK Board (main)
  
In progress
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AshrafAlam @CyberZujo @T-450 and others