Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpENer/source/src/cip /cipcommon.c link:1407 #488

Open
superPN opened this issue Dec 22, 2023 · 1 comment
Open

OpENer/source/src/cip /cipcommon.c link:1407 #488

superPN opened this issue Dec 22, 2023 · 1 comment

Comments

@superPN
Copy link

superPN commented Dec 22, 2023

This does not seem to match the latest standards of Ethernet/IP
in "switch(*message_runner)"

Your processing logic is like this:
If "Logical Format" is 01 (LOGICAL_SEGMENT_FORMAT_SIXTEEN_BIT)
Will execute "message_runner += 2;" and then obtain the information
That is, skip the current Logical Segment (one byte) and then skip an additional byte to obtain the data.

But in the latest Ethernert/IP standard (Vol1_3.33 page:1442), whether to skip an extra byte depends on the "Logical Segment
Type ",if"Logical Segment Type " is 111(Extended Logical), there is an extra byte to record "Extended Logical Type", and "Logical
Format" doesn't matter.

@EIPStackGroup EIPStackGroup deleted a comment from superPN Jan 8, 2024
@MartinMelikMerkumians
Copy link
Member

Thanks, I am aware that the current version is not up-to-date with the latest specification.

I deleted your image, and I need to ask you not to post screenshots from the specification, as this could lead to a takedown notice, as the specification is not an open document and copyrighted to the ODVA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants