Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace print with proper logging #280

Open
ma-sadeghi opened this issue Sep 22, 2023 · 1 comment
Open

Replace print with proper logging #280

ma-sadeghi opened this issue Sep 22, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@ma-sadeghi
Copy link

It'd be great if you could use proper logging instead of print-to-console. This is especially useful if impedance.py is being used by a third-party package that requires granular control over what gets printed/logged.

if M % 10 == 0:
print(M, mu, rmse(eval_linKK(elements, ts, f), Z))

@mdmurbach mdmurbach added the good first issue Good for newcomers label Nov 24, 2023
@mdmurbach
Copy link
Member

This is a great suggestion and would be a great addition to the package for better usability. Unfortunately, I don't have the bandwidth at this point to commit to making this switch, but would be a great contribution if you (or anyone else) wanted to take it on. I'll leave this issue open as a reminder for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants